Container Registry should be enabled when gitlab_registry_external_url is referenced

[flavienbwk]

Hi,

The official GitLab documentation states that the Container Registry turns active when gitlab_registry_external_url is referenced.

However, the template file of ansible-role-gitlab only enables it when gitlab_registry_enable: true is set.

# GitLab registry.
registry['enable'] = {{ gitlab_registry_enable | lower }}
{% if gitlab_registry_enable %}
registry_external_url "{{ gitlab_registry_external_url }}"
registry_nginx['ssl_certificate'] = "{{ gitlab_registry_nginx_ssl_certificate }}"
registry_nginx['ssl_certificate_key'] = "{{ gitlab_registry_nginx_ssl_certificate_key }}"
{% endif %}

Expected behavior :

registry['enable'] property should be set to true when the ansible gitlab_registry_external_url is provided. This is the default behavior in classic Omnibus install of GitLab.

Side problem :

The README of this repo shows the following :

gitlab_ssl_certificate: "/etc/gitlab/ssl/{{ gitlab_domain }}.crt"
gitlab_ssl_certificate_key: "/etc/gitlab/ssl/{{ gitlab_domain }}.key"

But the following variables :

registry_nginx['ssl_certificate'] = "{{ gitlab_registry_nginx_ssl_certificate }}"
registry_nginx['ssl_certificate_key'] = "{{ gitlab_registry_nginx_ssl_certificate_key }}"

Get the following values :

registry_nginx['ssl_certificate'] = "/etc/gitlab/ssl/gitlab.crt"
registry_nginx['ssl_certificate_key'] = "/etc/gitlab/ssl/gitlab.key"

Thanks,