ansible-role-git icon indicating copy to clipboard operation
ansible-role-git copied to clipboard

Use the git_install_path when determining the git version

Open ajxb opened this issue 2 years ago • 1 comments

There are a few small issues that break idempotence when a custom git_install_path is used:

  1. When {{ git_install_path}}/bin isn't in the PATH environment variable
  2. When {{ git_install_path}}/bin has a lower precedence than a system installed version of git

Presumably when git_install_path is used, the expectation is that git will be built and installed under the following conditions:

  • if git isn't present on that path or...
  • the version of git found under {{ git_install_path}}/bin is different to the version specified in git_version

This proposed change ensures that you always check the specific git executable found at the path defined in git_install_path and don't accidentally pick up any other git installation.

ajxb avatar Sep 13 '23 12:09 ajxb

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Jan 14 '24 16:01 github-actions[bot]

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

github-actions[bot] avatar Mar 17 '24 16:03 github-actions[bot]