ansible-role-docker icon indicating copy to clipboard operation
ansible-role-docker copied to clipboard

Published 20 hours ago • verified publisher icon geerlingguy

feat: use `ansible_facts` rather than `variables`

Open jackhodgkiss opened this issue 2 years ago • 13 comments

This PR addresses the issue raised in #422 by replacing ansible_ with ansible_facts. counterparts.

Has been tested numerous times within Ubuntu 22.04.

jackhodgkiss avatar Sep 14 '23 12:09 jackhodgkiss

LGTM

markgoddard avatar Sep 28 '23 13:09 markgoddard

Seems like there's a merge conflict—happy to merge once that's fixed up!

geerlingguy avatar Sep 28 '23 16:09 geerlingguy

Merge conflict resolved.

jackhodgkiss avatar Oct 08 '23 15:10 jackhodgkiss

How's this looking now @geerlingguy?

markgoddard avatar Oct 24 '23 08:10 markgoddard

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Feb 26 '24 06:02 github-actions[bot]

@geerlingguy please could you merge this one? Thanks

markgoddard avatar Feb 26 '24 09:02 markgoddard

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Jul 08 '24 06:07 github-actions[bot]

:(

markgoddard avatar Jul 08 '24 10:07 markgoddard