MetaGPT icon indicating copy to clipboard operation
MetaGPT copied to clipboard

Integrated Milvus with MetaGPT

Open Jacksonxhx opened this issue 1 year ago • 5 comments

Features

  • add another vector database milvus into MetaGPT

Feature Docs

Influence

Result

Other

Jacksonxhx avatar Aug 20 '24 09:08 Jacksonxhx

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.95506% with 57 lines in your changes missing coverage. Please review.

Project coverage is 60.04%. Comparing base (ab846f6) to head (4d92fdc). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
metagpt/document_store/milvus_store.py 32.00% 34 Missing :warning:
metagpt/rag/factories/retriever.py 11.11% 8 Missing :warning:
metagpt/rag/retrievers/milvus_retriever.py 0.00% 6 Missing :warning:
metagpt/rag/schema.py 75.00% 5 Missing :warning:
metagpt/rag/factories/index.py 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
- Coverage   62.59%   60.04%   -2.55%     
==========================================
  Files         287      289       +2     
  Lines       17589    17677      +88     
==========================================
- Hits        11009    10615     -394     
- Misses       6580     7062     +482     
Flag Coverage Δ
60.04% <35.95%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 25 '24 03:09 codecov-commenter

Can anyone help to review this PR? We are appreciate this MetaGPT project and hope Milvus can be integrated into it.

We found that if pymilvus dependency is added, it will conflict with some existing dependencies, so in the code, pymilvus dependency is commented out and lazy imported.

zc277584121 avatar Sep 25 '24 06:09 zc277584121

@better629

zc277584121 avatar Sep 25 '24 07:09 zc277584121

Hey, bro. I have meet the similar problem when I install it, so I have make some changes on dependency, in case that less version specified in .whl, my repo is MetaGPT-simple and you can install it with python -m pip install metagpt-simple, the pypi official link is metagpt-simple. Of course, I only do some simple test on it, if some error occur, please let me know.

EvensXia avatar Sep 25 '24 08:09 EvensXia

Thanks for your suggestion. I saw that you lifted the version restrictions of all dependencies. But I think it may introduce new problems, that is, some of the latest versions of some dependencies may not be backward compatible, resulting in them not supporting the code of this project. I think the maintainer of this project needs to ensure the operability of the newer dependencies, and use some more powerful dependency management tools to manage dependencies, such as poetry. Maybe this is a better solution.

zc277584121 avatar Sep 26 '24 02:09 zc277584121

I performed the following operations:

  1. pip install llama-index-vector-stores-milvus==0.1.23
  2. Modify milvus_connection to my own milvus
  3. pytest tests/metagpt/document_store/test_milvus_store.py

Finally, the Collection was successfully created. image

voidking avatar Oct 15 '24 11:10 voidking

LGTM

voidking avatar Oct 15 '24 11:10 voidking