eloquent-filemaker icon indicating copy to clipboard operation
eloquent-filemaker copied to clipboard

Always Log FM Query to clockwork

Open kostaszazim opened this issue 1 year ago • 2 comments
trafficstars

Hi! in src/Services/FileMakerConnection.php would that be possible to move line 744 after line 721 in order to always fire the QueryExecuted event? This should log the query to clockwork even with no results returned. Because now if you get back no results nothing is logged to clockwork and it is difficult to debug the actual query made to filemaker Data API.

kostaszazim avatar Jul 07 '24 00:07 kostaszazim

We've actually had some discussions about this internally already. We may add something in there or put a slightly different response in the log when there's an error like that.

Smef avatar Jul 08 '24 20:07 Smef

PR: https://github.com/gearbox-solutions/eloquent-filemaker/pull/77

Smef avatar Jul 30 '24 16:07 Smef

Merged and released.

Smef avatar Aug 30 '24 14:08 Smef