Greg Dubicki

Results 413 comments of Greg Dubicki

Hi @jakemalley ! Why do we need extra `noop` fields if in both of these types we already have `status` with the same information?

I had a feeling that this is because of the way we assign that status now. I am pretty new to the project so I have doubts about the approach...

Partially done in #220.

I would extend the [pattern of the PuppetDB cli's configuration file order](https://github.com/puppetlabs/puppetdb-cli/blob/main/man/puppetdb_conf.pod#description) with reading also `./puppetdb.conf`, if it is present. This would allow the users of multiple PuppetDBs (like testing...

Hi @ngmmatos ! This is not possible as of now but we are open to a PR that would add this feature. :)

I confirm that it works on Ruby 1.9.2 and Memcached 1.4.17 on Centos 5. But I had to also apply this https://github.com/etsy/mctop/pull/24 to make it work.

I think that `pipx` should remain the _recommended_ way to install `tsrc` but we can add a line saying that you can also use plain `pip`, if you know what...

> I find it weird that this is an option in the manifest ... I was expecting an other `tsrc` sub-command or a flag in `tsrc sync` You are right....

> > I propose to switch this to a flag like tsrc sync [-c/--correct-branch]. Ok, @dmerejkowsky? > > Sounds good. Go for it :) Done. Can you please review?