Greg Chapple

Results 64 comments of Greg Chapple

Cool. So I guess this PR should be put on hold then until that is resolved? I'll update with the example above, then fix the failing test when the cursor...

Just did a quick test in vim. Normal mode - Pressing `$` brings me to the last character on the current line, not beyond. Visual mode - Pressing `$` brings...

My feeling is that `\n` should not be counted as part of the line. So given the following line of code: ``` func test() int { ``` `{` should be...

So then cursors need some way of knowing whether or not to include that character. Simplified example: ``` go func (c *Cursor) EOL(includeNewline bool) bool { l := len(c.Line.Data) if...

Fair enough. In that case it will be slight different to how vim handles it, albeit simpler. Which is fine by me :+1:

In normal mode, vims cursor will not go the the newline character. It stops at whatever is before it. On 6 Jun 2014 23:44, "Kamil Kisiel" [email protected] wrote: > How...

Ah, sorry, I misunderstood you earlier. I was thinking more about the visual representation of this, rather than the functional bit underneath. You're right. Should vigo stick with the "religious"...

I think so. Mostly anyways. I use Linux, but I work with some developers who use windows. Occasionally I will see some strange line endings sneaking around, but not often.

Ok, cool. So, what steps need to be taken on this issue then? I'll have a few hours free this evening to put together a patch, unless you've already got...

In vim CtrlV starts rectangular selection, if I'm not mistaken