Update command_maker.py

[wpalhares]

trafficstars

Add delete option from command

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[gchamon]

Hey there! Thanks for the pull request!

Could you elaborate a bit more on the use case? Maybe provide an example of how this argument is supposed to work. Thanks!

[wpalhares]

Hi man, folow de link with explanation

https://linux.die.net/man/1/rsync

--delete delete extraneous files from dest dirs --delete-before receiver deletes before transfer (default) --delete-during receiver deletes during xfer, not before --delete-delay find deletions during, delete after --delete-after receiver deletes after transfer, not before --delete-excluded also delete excluded files from dest dirs

WILSON ROBERTO PALHARES Especialista de Sistemas de TI TI - Desenvolvimento Contato: (065)3645-8000 | Ramal: 8796 Escritorio Cuiaba | Cidade: Cuiaba - MT [http://wkf.bomfuturo.com.br/assinatura.png]

---

De: Gabriel Chamon Araujo @.> Enviado: sexta-feira, 17 de novembro de 2023 17:25 Para: gchamon/sysrsync @.> Cc: WILSON ROBERTO PALHARES @.>; Author @.> Assunto: Re: [gchamon/sysrsync] Update command_maker.py (PR #35)

Você não costuma receber emails de @.*** Saiba por que isso é importantehttps://aka.ms/LearnAboutSenderIdentification Atenção: Esse é um e-mail externo e pode ser malicioso. Por favor tenha cuidado ao clicar em links e abrir anexos. Qualquer duvida favor procurar o departamento de Ti.

Hey there! Thanks for the pull request?

Could you elaborate a bit more on the use case? Maybe provide an example of how this argument is supposed to work. Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/gchamon/sysrsync/pull/35#issuecomment-1817127168, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS64GPMNIEPX227HNLWMLNLYE7I5VAVCNFSM6AAAAAA7QMDVWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGEZDOMJWHA. You are receiving this because you authored the thread.Message ID: @.***>

[gchamon]

I am sorry, I wasn't clear about what I wanted. I understand that delete is an option in the underlying rsync command. What I really wanted to know is how this option would be used in the context of this package. Should it be exposed in the run command? Must the user always use get_rsync_command to use it?

Also, I don't see how this pull request passes --delete to the final list of flags. Have you tested this modification?

Maybe you could add this information to the readme.md and add tests to illustrate the use. If you don't have time, please outline how should I write the tests and the examples for the readme.md.

Thanks again for the interest in this project!

[wpalhares]

I understand the need for more evidence. In this case without the option --delete, the extra files are not deleted, generating a volume of garbage at the destination,. But that's ok, due to the lack of time to better demonstrate it, I am using the subprocess.run command to help me at this time, thank you for the feedback man.

WILSON ROBERTO PALHARES Especialista de Sistemas de TI TI - Desenvolvimento Contato: (065)3645-8000 | Ramal: 8796 Escritorio Cuiaba | Cidade: Cuiaba - MT [http://wkf.bomfuturo.com.br/assinatura.png]

---

De: Gabriel Chamon Araujo @.> Enviado: sábado, 18 de novembro de 2023 09:14 Para: gchamon/sysrsync @.> Cc: WILSON ROBERTO PALHARES @.>; Author @.> Assunto: Re: [gchamon/sysrsync] Update command_maker.py (PR #35)

Você não costuma receber emails de @.*** Saiba por que isso é importantehttps://aka.ms/LearnAboutSenderIdentification Atenção: Esse é um e-mail externo e pode ser malicioso. Por favor tenha cuidado ao clicar em links e abrir anexos. Qualquer duvida favor procurar o departamento de Ti.

I am sorry, I wasn't clear about what I wanted. I understand that delete is an option in the underlying rsync command. What I really wanted to know is how this option would be used in the context of this package. Should it be exposed in the run command? Must the user always use get_rsync_command to use it?

Also, I don't see how this pull request passes --delete to the final list of flags. Have you tested this modification?

Maybe you could add this information to the readme.md and add tests to illustrate the use. If you don't have time, please outline how should I write the tests and the examples for the readme.md.

Thanks again for the interest in this project!

— Reply to this email directly, view it on GitHubhttps://github.com/gchamon/sysrsync/pull/35#issuecomment-1817506659, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS64GPPGPWVRIRZF7G36EI3YFCYEBAVCNFSM6AAAAAA7QMDVWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGUYDMNRVHE. You are receiving this because you authored the thread.Message ID: @.***>