Gregory Casamento
Gregory Casamento
@fredkiefer I believe I have adequately answered all concerns.
@fredkiefer Please take a look.
> > @fredkiefer I believe I have adequately answered all concerns. > > > > I see plenty of comment that where not addressed. If you want to ignore them...
> [MainMenu-enumerated.txt](https://github.com/gnustep/libs-gui/files/8237467/MainMenu-enumerated.txt) > > In this nib, it appears as though Apple has created a class named NSCollectionViewCore to handle some NSCollectionView responsibilities. Also, it seems that they are using...
@fredkiefer All I see left is our disagreement about _selectionIndexPaths and _selectionIndexes. I will do further research to see if there is, indeed, a relationship between these two variables. Please...
I just added this test... https://github.com/gcasa/NSCollectionViewArray_test it seems we have some deeper concerns. This test works on macOS but does NOT work correctly on GNUstep. This means that Testplant (now...
I am wondering if I couldn't do something like this... ``` NSMutableIndexSet *indexSet = [NSMutableIndexSet indexSet]; for (NSIndexPath *indexPath in indexPathsSet) { [indexSet addIndex:indexPath.row]; } NSIndexSet *convertedIndexSet = [indexSet copy];...
As additional proof ``` 2023-02-12 11:31:58.746793-0500 NSCollectionViewLayout_test[71987:20745783] selectionIndexes: [number of indexes: 1 (in 1 ranges), indexes: (1)] 2023-02-12 11:31:58.746848-0500 NSCollectionViewLayout_test[71987:20745783] selectionIndexPaths: _NSCollectionViewMutableIndexPathSet {0:(1)} ``` when the datasource method numberOfSectionsInCollectionView: returns...
> All the changes in GSSocketStream.m do is add explicit casts to say that variables are of the type that the compiler already knows they are. That's not actually harmful...
Was this ever fully addressed?