Gregory Casamento

Results 197 comments of Gregory Casamento

@fredkiefer Please take another look. Again, future PRs will be smaller. Apologies

@fredkiefer Are there any additional changes you feel are needed here?

@fredkiefer Can we take an iterative approach on this? I don't want us to get stuck in a cycle of review. My concern is trying to refactor NSOutlineView to make...

@fredkiefer Please review and flag any final issues. Currently, the test is working as expected and matches the behavior that is evident on macOS. Can any additional concerns be addressed...

> This PR is so huge, whenever I look I still find wrong bits I never inspected before. And then there are new bugs that must have been inserted with...

> This PR is so huge, whenever I look I still find wrong bits I never inspected before. And then there are new bugs that must have been inserted with...

@fredkiefer The more I dig into this the more I am convinced that this is a special case for NSOutlineView. There are a couple of reasons for this... * While...

> The code is working, maybe this is as much as we can achieve. I am doing some experiments to see if we can improve the code at least in...

I'm going to merge what we have and keep working on this and simplify it as much as possible. There is additional integration with NSBrowser and I am HOPING it...

> @gcasa if you have to, merge this. The code reminds me a lot of the mess we had in NSArrayController before I rewrote the complete implementation there. After that...