gb-asm-tutorial
gb-asm-tutorial copied to clipboard
gbdev
Adds title screen section to tutorial
Feature adds a title-screen directory with asm code that boots the game onto a "title screen" and after pressing start switches to the "game screen".
Closes https://github.com/gbdev/gb-asm-tutorial/issues/39
Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay. This code doesn't interact with the rest of the unbricked game. Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.
Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay.
I might be confused on the project layout in this case. It seems like every section has its own subdirectory for each section of the tutorial that I tried to replicate for the title screen.
This code doesn't interact with the rest of the unbricked game.
Could you clarify? The way this sentence is structured has 2 meanings, either it should interact and isn't, or it shouldn't interact and is.
Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.
Issue #39 states "please propose an implementation, and send it in as a draft pull request. After a maintainer has greenlit your implementation, you can start writing the tutorial text, which describes the implementation."
Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay.
I might be confused on the project layout in this case. It seems like every section has its own subdirectory for each section of the tutorial that I tried to replicate for the title screen.
This code doesn't interact with the rest of the unbricked game.
Could you clarify? The way this sentence is structured has 2 meanings, either it should interact and isn't, or it shouldn't interact and is.
Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.
Issue #39 states "please propose an implementation, and send it in as a draft pull request. After a maintainer has greenlit your implementation, you can start writing the tutorial text, which describes the implementation."
Okay, you are correct i misread the request and had to double-check on the format of the unbricked repo code.
After compiling, when i run the game, i see the splash screen.
Upon pressing the start button, i proceed to the next screen.
Codewise, Everything looks solid. Everything works fine when the ROM is compiled. The only thing i'm unsure about is during the 'TitleScreenLoop', if it's neccessary to wait for the vblank phase or not? Besides that, i think it looks ok.
Since there's nothing else going on aside from a poll it's not strictly necessary. I could explain it in the description. Alternatively I could move the WaitVBlank2 to the top of the loop and create a third WaitVBlank in the original spot of the second one.
Btw, what position is this section in? I'm about to start writing the description and I want to stay within the timeline of events.
Hey @wilkersonrdevon , sorry for being late!
Codewise, Everything looks solid. Everything works fine when the ROM is compiled. The only thing i'm unsure about is during the 'TitleScreenLoop', if it's neccessary to wait for the vblank phase or not? Besides that, i think it looks ok.
Since there's nothing else going on aside from a poll it's not strictly necessary. I could explain it in the description. Alternatively I could move the WaitVBlank2 to the top of the loop and create a third WaitVBlank in the original spot of the second one.
I'd go for the first option and avoid adding a third WaitVBlank.
Btw, what position is this section in? I'm about to start writing the description and I want to stay within the timeline of events.
If I remember correctly, the idea was to add this Title Screen in Part 2 but I don't have a strong opinion regarding where to introduce this. Do you need concepts explained in other paragraphs of Part 2? I'd put it after "Bricks" for now..
Remember to mark the PR as ready to review whenever you feel like you're in a satisfying starting point.
If this section is going to be after https://gbdev.io/gb-asm-tutorial/part2/functions.html it should probably use the Memcopy function to copy the tile data etc. right?
