httpexpect icon indicating copy to clipboard operation
httpexpect copied to clipboard

tests: fix expected filename in TestRequestBodyMultipartFile

Open clobrano opened this issue 3 years ago • 3 comments
trafficstars

currently TestRequestBodyMultipartFile expect the filename given by

func (*multipartPart) FileName() string

to be a fullpath in one of the test cases, however the documentation states that:

the filename is passed through filepath.Base (which is platform dependent) before being returned.

then the test fails.

This change fix the expected filename for this test, using the same filepath.Base function.

Fixes: #103

clobrano avatar Jun 14 '22 12:06 clobrano

Hi @clobrano @EstebanJesus any chance this PR and all other PRs that are failed due to this can be merged sooner?

Maybe also @gavv ?

aries-zhang avatar Jun 16 '22 11:06 aries-zhang

Hi @aries-zhang, I really don't know what the strategy is like, but I don't see a problem with it.

EstebanJesus avatar Jun 16 '22 21:06 EstebanJesus

Hey, let me know if there is more I can do to improve this PR.

clobrano avatar Jun 23 '22 14:06 clobrano

Hi, sorry for delay! Thanks!

gavv avatar Nov 12 '22 19:11 gavv

Follow-up commit a54cf58c872b620d00b71cc961822765ae316d64 to fix the build completely

gavv avatar Nov 12 '22 19:11 gavv