github-action-markdown-link-check icon indicating copy to clipboard operation
github-action-markdown-link-check copied to clipboard

Check Link not working - Not detecting broken links.

Open javierhf opened this issue 2 years ago • 7 comments
trafficstars

Issue Description The link checker is not identifying the broken links anymore. A few weeks ago (months?) the action worked.

Current Workflow Configuration

on: [push]  
name: Check links  
jobs:  
  markdown-link-check:  
    runs-on: project-runner  
    steps:  
    - uses: actions/checkout@master  
    - uses: gaurav-nelson/github-action-markdown-link-check@v1  
      with:  
        use-quiet-mode: 'yes'  
        use-verbose-mode: 'yes'  
        config-file: '.github/workflows/markdown.links.config.json'  
        folder-path: 'docs'    

Current markdown.links.config File Configuration

The file show the links use cases not the current links. We use regular expression

{
    "ignorePatterns": [
    {
    "pattern": "^https://project-web.com"
    },
    {
    "pattern": "^https://project-web/_Beach_/"    
    },
    {
    "pattern": "^https://www.ai.ai/waf.jsp"    
    },
    {
    "pattern": "^http://ghost:234234234/stone/temple/pilots"    
    },
    {
    "pattern": "^https://valarmorgulis.com/**.coc"    
    },
    {
    "pattern": "^https://project-web.com/dasdad?Fadad=OK&proj=dasbox-truelen"    
    },
    {
    "pattern": "^https://project-web.com/_whatsup?delay=0sec"    
    },
    {
    "pattern": "^https://project-web.com/(.+)"
    },
    {
    "pattern": "^https://project-web.com/tomatos/bodytypes?rket=GB&fruitAll=true&sizeFruit=apple"
    },
    {
    "pattern": "^https://project-web.com/[A-Za-z]+-([A-Za-z0-9]+(/[A-Za-z0-9]+)+)$"
    },
    {
    "pattern": "^https://github.com/asdasda/asasd-htrthy-234greg/.*/(.+)"
    },
    {
    "pattern": "^https://github.com/sadfsdfsdf/([A-Za-z]+(-[A-Za-z]+)+)$"
    },
    {
    "pattern": "^https://supersec.com/[A-Za-z]+/$"
    },
    {
    "pattern": "^https://project-web.com/uncle-bob/([A-Za-z]+(-[A-Za-z]+)+)/$"
    },
    {
    "pattern": "^https://project-farmer/([A-Za-z]+(-[A-Za-z]+)+)/([A-Za-z]+(-[A-Za-z]+)+).[A-Za-z]+$"
    },
    {
    "pattern": "^https://project-web.com/ord/$"
    },
    {
    "pattern": "^https://supersec.com/[A-Za-z]+/$"
    },
    {
    "pattern": "^https://github.com/*/**/*.pop"
    },
    {
    "pattern": "^https://book-list.com/[A-Za-z]+/[A-Za-z]+-[A-Za-z]+/[A-Za-z]+/[A-Za-z]+-[A-Za-z]+/[A-Za-z]+.[A-Za-z]+$"
    },
    {
    "pattern": "^https://project-web-stromae.com/v2/index.html"
    },
    {
    "pattern": "^https://project-web-stromae.com/v2/#overview-3"
    }
    ]
    }

Tests Done

  • Using the lastest version of the action does not work.
  • Testin with other setups (for example onlu-for-modified files) does not work.

javierhf avatar Aug 07 '23 16:08 javierhf

I noticed the same issue. I tried older versions down to 1.0.12, but it's still not working anymore. Not sure since when though.

If you use the markdown-link-check project, which is used by this action, the broken links are detected, so not sure what is causing the issue.

fharper avatar Sep 19 '23 18:09 fharper

I noticed the same issue. I tried older versions down to 1.0.12, but it's still not working anymore. Not sure since when though.

If you use the markdown-link-check project, which is used by this action, the broken links are detected, so not sure what is causing the issue.

Thanks for the tip, @fharper . I will try that.

javierhf avatar Sep 20 '23 09:09 javierhf

I am experiencing the same issue. I was trying other things and I happened to remove ignorePatterns from config file and it starts reporting broken links. May be something broken on how those are parsed for exclusion while checking for broken links.

sdesani avatar Oct 04 '23 03:10 sdesani

I am also experiencing this issue. Thank you @fharper and @sdesani for the hints.

mahula avatar Nov 07 '23 07:11 mahula

Have you checked you have the right file extension for the lycheeignore file?

javierhf avatar Nov 16 '23 22:11 javierhf

I had the same issue here, with a solution too.

Spoiler: there was a comma missing in mlc_config.json:

richel@richel-N141CU:~/GitHubs/bianca_workshop$ git diff
diff --git a/mlc_config.json b/mlc_config.json
index 95ee752..d4e5819 100644
--- a/mlc_config.json
+++ b/mlc_config.json
@@ -1,5 +1,5 @@
 {
-    "aliveStatusCodes": [0, 40, 200, 401, 403, 418, 500, 503]
+    "aliveStatusCodes": [0, 40, 200, 401, 403, 418, 500, 503],
     "ignorePatterns": [
         {
             "pattern": [

richelbilderbeek avatar Dec 12 '23 08:12 richelbilderbeek

Update: I have stopped working on this action. Please try https://github.com/UmbrellaDocs/linkspector and https://github.com/UmbrellaDocs/action-linkspector instead.

gaurav-nelson avatar May 14 '24 12:05 gaurav-nelson