github-action-markdown-link-check icon indicating copy to clipboard operation
github-action-markdown-link-check copied to clipboard

Fix defaults handling, perform linting

Open sammcj opened this issue 3 years ago • 1 comments
trafficstars

This PR is for two things:

  1. Currently when trying to use this Action linting/actionlint fails because all optional inputs are marked as required: true.

Screen Shot 2022-09-20 at 9 05 52 am

I have refactored the bash parameters to set the defaults if no input is provided, and set the inputs to optional.

  1. Fixed numerous markdown formatting errors.

cc/ @gaurav-nelson

sammcj avatar Sep 19 '22 23:09 sammcj

The two markdown link errors are both false positives @gaurav-nelson

Screen Shot 2022-09-21 at 7 52 32 am

sammcj avatar Sep 20 '22 21:09 sammcj

@gaurav-nelson do you know what's up with those false positive link checks?

sammcj avatar Sep 26 '22 01:09 sammcj

For GitHub can you see https://github.com/gaurav-nelson/github-action-markdown-link-check/issues/136#issuecomment-1117148640 and add it to the mlc-config file ?

The other one is probably disallowing agents. maybe add it to ignore list as well.

gaurav-nelson avatar Sep 26 '22 10:09 gaurav-nelson

@gaurav-nelson thanks, done :)

sammcj avatar Sep 26 '22 23:09 sammcj

@sammcj Can you please check the script again, I think the failed workflow is not running with the --config option. I am not sure though.

Also, See https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650177#step:3:154 which outputs the command we are running however the failed check doesn't list the command https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650203? 🤔

gaurav-nelson avatar Sep 28 '22 02:09 gaurav-nelson

@gaurav-nelson Oh I see what's going on, it's relying on on all inputs being provided in order to have each parameter in the right place.

OK I'll refactor!

sammcj avatar Sep 28 '22 03:09 sammcj