gatsby icon indicating copy to clipboard operation
gatsby copied to clipboard

chore(gatsby): convert babel-loaders to typescript

Open Kornil opened this issue 3 years ago • 2 comments

Convert babel-loaders to TS.

Related Issues

https://github.com/gatsbyjs/gatsby/issues/21995

Kornil avatar Aug 04 '22 08:08 Kornil

Thanks for the import changes @LekoArts I was not sure how to proceed since it was dynamically imported. I checked the tests and they still seem unrelated e2e tests.

Kornil avatar Aug 04 '22 13:08 Kornil

Thanks for the import changes @LekoArts I was not sure how to proceed since it was dynamically imported. I checked the tests and they still seem unrelated e2e tests.

We have a few tests that are notoriously flaky that we're trying to resolve. I think they're all unrelated... I kicked them off again.

Thank you for your contribution 💜

imjoshin avatar Aug 09 '22 19:08 imjoshin

I'm quite unlucky with these tests, I've checked them again to be safe, mostly remote-file.js that seem to be a common one across all my PRs (unrelated) and something from gatsby-script that seem unrelated as well.

Kornil avatar Aug 10 '22 09:08 Kornil

@Kornil thanks again for going through the rebase. We appreciate all that you do!

imjoshin avatar Aug 11 '22 17:08 imjoshin