Garrett Jones

Results 19 comments of Garrett Jones
trafficstars

We can wait for after google-cloud-java GA to fix this because the GAPIC clients won't go GA at that time.

As the comment says ("only merging with gRPC default value for User-Agent is permitted"), the user-agent value is merged with the grpc one. Assigning to @vam-google for any follow-up questions.

I believe that the timeout in ApiCallContext is really just meant for the timeout of a single attempt - @vam-google can clarify.

@bjwatson I hand-converted the proto 2 file for InstancesService to proto 3 (and put that in compute_instances.proto), hand-converted the service yaml, used the gapic config generator to create the gapic...

In PHP, we just created CallSettings. I had this same thought about the confusion of CallOptions and CallSettings. In a case where you want both as classes, I might suggest...

I currently like ApiCallableSettings.

@chingor13 they only reference the same dependencies if all of the service artifacts you use are built against the same shared library version, but there seem to be 3-4 shared...

Yep, weekly is probably fine for BOM release cadence.