garethr-docker icon indicating copy to clipboard operation
garethr-docker copied to clipboard

Make docker::run use $service_name instead of "docker"

Open benningm opened this issue 8 years ago • 2 comments

When using the module with 'docker-latest' packages from RedHat the systemd service of docker is also 'docker-latest'. There is already a $service_name variable for this, but 'docker' is still hardcoded in some strings.

This replaces hardcoded 'docker' strings with $service_name.

benningm avatar May 12 '17 13:05 benningm

Your PR is missing service overrides template: https://github.com/garethr/garethr-docker/blob/master/templates/etc/systemd/system/docker.service.d/service-overrides-rhel.conf.erb#L2

gdlx avatar Jul 10 '17 08:07 gdlx

Just added the service overrides and resynced with upstream

benningm avatar Jul 11 '17 10:07 benningm