elm-visualization icon indicating copy to clipboard operation
elm-visualization copied to clipboard

Axis ticks color

Open jjagielka opened this issue 6 years ago • 2 comments

There's a common D3 axis trick to set the ticks hight to a negative value to obtain a grid. We can use that trick here as well, but the lines are drawn with stroke "#000" resulting in strong black lines.

A quick improvement would be to change the stroke value to "currentColor".

Ref: https://css-tricks.com/currentcolor/

jjagielka avatar Sep 27 '19 14:09 jjagielka

It's possible to override the color with css

    .chart_axisGrid .tick > line {
      stroke: $grey-lighter;
    }

ffigiel avatar Feb 21 '21 18:02 ffigiel

I guess the idea here is that currentColor might be a better default, since the charts would adapt automatically to the colour of surrounding typography. However, this would be a breaking change (as the output of axes is to be depended upon), so I am unsure about this. I'll punt on it until we are ready to make the next major release (which to be clear, is not going to be in the short term).

gampleman avatar Feb 23 '21 08:02 gampleman