unity-test-runner icon indicating copy to clipboard operation
unity-test-runner copied to clipboard

[SUGGESTION] Not having any edit mode tests and using testMode: all will cause a timeout and the action will fail

Open Zh4rsiest opened this issue 3 years ago • 1 comments

Bug description

This might not be a bug at all because you could assume that one has edit mode tests as well when running unity-test-runner with testMode: all option, but the error message was not easy for a beginner to understand. The error message was the following after # Testing in COMBINE_RESULTS #:

Aborting batchmode due to failure:
Timeout after 300 seconds while waiting async operations to finish. executeMethod ''

Although I don't have enough knowledge about unity-actions I think it should be mentioned either in the documentation for the testMode parameter, or in https://game.ci/docs/troubleshooting/common-issues

How to reproduce

  • Don't have any edit mode tests
  • Set unity-test-runner's testMode parameter to all or leave it empty as the default value is all
  • the unity-test-runner job will fail

Expected behavior

Not sure if this should be it, but the job shouldn't perform any edit mode tests if there aren't any

Additional details

This is merely a suggestion as like I stated before, I'm not knowledgeable enough on how this works 😬

Zh4rsiest avatar Nov 29 '22 19:11 Zh4rsiest

Thank you for your suggestion.

Marking this as an enhancement, as that is the behaviour from the unity editor, but we can probably work around it somehow.

webbertakken avatar Nov 29 '22 21:11 webbertakken