unity-test-runner icon indicating copy to clipboard operation
unity-test-runner copied to clipboard

Add support for macos

Open Kariaro opened this issue 2 years ago • 4 comments

Context I need to test that external libraries work in Windows, Linux and Macos.

Currently macos is not supported. That's why I'm making this issue

Suggested solution

Copy code from game-ci/unity-builder that handles darwin systems and use it in this repository

Additional details

I'm going to try make a PR for this issue myself and will clone this repository to start testing

Kariaro avatar Dec 27 '22 14:12 Kariaro

Yup! We support this approach and accept contributions.

webbertakken avatar Dec 27 '22 14:12 webbertakken

I'm currently looking at the generated docker images for macos but I don't see any here: https://github.com/game-ci/docker/tree/main/images/macos

Should I copy the MacBuilder concept from https://github.com/game-ci/unity-builder/blob/main/src/model/mac-builder.ts and apply it so that if process.platform === 'darwin' I jump to the MacTestRunner instead?

Kariaro avatar Dec 27 '22 15:12 Kariaro

That's right, there are no docker images for macos, so you would likely need to copy the relevant typescript code from unity-builder.

davidmfinol avatar Dec 27 '22 15:12 davidmfinol

Any news here? Any help needed?

MichaelGlaive avatar Jul 30 '24 13:07 MichaelGlaive