unity-test-runner icon indicating copy to clipboard operation
unity-test-runner copied to clipboard

Mount known_hosts from home directory for using ssh-agent on self-hosted runner

Open chromee opened this issue 3 years ago • 3 comments

When using self-hosted runner, name of the user running runner is not necessarily the runner. So known_hosts need to be mounted from .ssh folder in home directory of user running self-hosted runner.

helped by @nikaera

Changes

  • mount .ssh/known_hosts from the running user's home directory

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Readme (updated or not needed)
  • [x] Tests (added, updated or not needed)

chromee avatar Jun 04 '22 09:06 chromee

Cat Gif

github-actions[bot] avatar Jun 04 '22 09:06 github-actions[bot]

Does the project get checked out in that home dir as well?

Should we be updating all occurrences of that directory?

webbertakken avatar Jun 04 '22 19:06 webbertakken

When installing the self hosted runner, specify a working directory for the runner. The project will be checked out to that working directory.

Yes, we should update where assuming GitHub runners.

chromee avatar Jun 05 '22 08:06 chromee

I lost context. What is the status of this PR?

webbertakken avatar Nov 03 '22 18:11 webbertakken

Sorry for the late reply. I found further improvements and will re-submit a PR. So I close this PR.

chromee avatar Nov 25 '22 10:11 chromee