unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

Fixed AWS to work when no secrets specified

Open brian-golfplusvr opened this issue 9 months ago • 2 comments

Changes

  • Updated AWS task definition related code so that it would allow creation of the cloud formation stack and not complain if the ContainerDefinition secrets were null

  • See Discord discussion

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [ ] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
  • [ ] Readme (updated or not needed)
  • [ ] Tests (added, updated or not needed)

Summary by CodeRabbit

  • New Features

    • Enhanced AWS CloudFormation template generation with improved secret management.
    • Added logging for better traceability during AWS job stack and task definition processes.
    • Introduced new input parameters cloneDepth and cloudRunnerRepoName for repository cloning operations.
    • Dynamic construction of Unity Builder repository URL based on configuration.
  • Refactor

    • Updated secret handling in CloudFormation template configuration.
    • Removed Secrets property from container definitions.
    • Changed imageRollingVersion property type from number to string for better data representation.
    • Added static getters for cloneDepth and cloudRunnerRepoName in CloudRunner options.
    • Modified cloning logic to include a depth parameter for optimization.
  • Chores

    • Improved code comments for clarity in secret template generation.

brian-golfplusvr avatar Jan 30 '25 22:01 brian-golfplusvr