unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

fix(windows): replacing of urls if gitPrivateToken is set

Open kijz opened this issue 1 year ago • 1 comments

Changes

  • Windows: fixed an error in set_gitcredential.ps1 where url. was inside of the string, resulting in errors when building with: gitPrivateToken

Related Issues

  • I think right now there is none

Related PRs

  • I think right now there is none

Successful Workflow Run Link

  • This only affects private repos. Cannot share a workflow run here unfortunately.
  • Comparing the changes to linux might suffice.

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
  • [x] Readme (updated or not needed)
  • [x] Tests (added, updated or not needed)

kijz avatar Apr 25 '24 18:04 kijz

Cat Gif

github-actions[bot] avatar Apr 25 '24 18:04 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.97%. Comparing base (f2250e9) to head (ca010b2).

:exclamation: Current head ca010b2 differs from pull request most recent head cda084b. Consider uploading reports for the commit cda084b to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files          77       77           
  Lines        3121     3121           
  Branches      645      645           
=======================================
  Hits         1154     1154           
  Misses       1824     1824           
  Partials      143      143           

codecov-commenter avatar May 15 '24 21:05 codecov-commenter

Released in v4.3.0.

webbertakken avatar Oct 07 '24 22:10 webbertakken