unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

Published 20 hours ago • verified publisher icon game-ci

Enable unity licensing server for Windows

Open Latylus opened this issue 1 year ago • 2 comments

Hello

A simple version of unity licensing server support for Windows using the same logic as the existing Linux implementation.

Changes

  • Modify the step files activate.ps1 and return_license.ps1 to replicate what is done in activate.sh and return_license.sh
  • Update validate-windows.ts to allow this option to pass through for a Windows build
  • Update docker.ts to correctly copy the unity config file necessary for unity licensing server request

Related PRs

  • 468 : the Linux implementation of this feature

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR in the documentation repo)
  • [x] Readme (not needed)
  • [x] Tests (not needed)

Latylus avatar Mar 14 '24 16:03 Latylus

Cat Gif

github-actions[bot] avatar Mar 14 '24 16:03 github-actions[bot]

LGTM. Can you confirm this works as expected?

We have tested this in our private repo and it works as intended (basically identical to the linux version)

Latylus avatar Mar 15 '24 14:03 Latylus

Hello @webbertakken , if any other changes are needed, I'd be glad to discuss or implement them. In the meantime, I'll try to keep this branch up to date to prevent any merging issue.

Latylus avatar Mar 26 '24 18:03 Latylus