unity-builder icon indicating copy to clipboard operation
unity-builder copied to clipboard

WIP: macOS module support & Android Library Support

Open Legoless opened this issue 3 years ago • 1 comments

Changes

This is a WIP PR (as we needed the fixes for our processes), as I didn't have enough time to go through the checklist and Windows is still missing Android Library support.

So there are several changes:

  • Injected build script now uses exportAsGoogleAndroidProject setting and applies it correctly.
  • Injected build script now applies buildAppBundle setting, if set specifically. Default remains that it's read from .aab in build path filename. This enables the setting to be applied while exporting the project.
  • If exportAsGoogleAndroidProject is enabled, filename doesn't include .aab or .apk anymore, thus giving us backwards support, otherwise the behaviour is the same as previously. Enable the setting in your workflow: exportAsGoogleAndroidProject: true
  • MacOS Setup now correctly installs modules for Mac, iOS, tvOS and Android, which allows you to perform all of those builds (for some reason, Ubuntu on GitHub Actions has issues building iOS projects, but Mac works, didn't look into details, but scenes are corrupted and game crashes at launch time).

Let me know your feedback and proposed changes. I'll also need help with testing, as we don't use Ubuntu machines much. Use blubblub/[email protected] to test the action.

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [ ] Readme (updated or not needed)
  • [ ] Tests (added, updated or not needed)

Legoless avatar Jul 28 '22 09:07 Legoless

Cat Gif

github-actions[bot] avatar Jul 28 '22 09:07 github-actions[bot]

Is this something you intend to finish or shall we close?

webbertakken avatar Dec 04 '22 00:12 webbertakken

Done by https://github.com/game-ci/unity-builder/pull/505

davidmfinol avatar Feb 14 '23 05:02 davidmfinol