global-agent
global-agent copied to clipboard
chore(deps): drop deprecated boolean module
Inlines the boolean module to address #70. Code repository is no longer available, code sourced via npm registry.
Checking in on this, @gajus is this something you would be open to reviewing?
Came here to see if this is being addressed. :+1: for the PR.
However, it should be noted that this function only parses for truthy and truthy-like values; which means it is not a parse boolean function since anything not truthy/truthy-like is just false. (may be rename to parseTruthy later and update references in codebase)
- Is the code and intent only to parse the possible truthy/truthy-like values?
- Did the original
booleanpackage do the same?
I tried testing it for weird values like { valueOf: () => 1 } and new Number(1) and new Number(0) It seems to work correctly.
Hello @gajus - just checking in. This library is excellent for enterprise users behind firewalls, but users are less likely to trust it due to the deprecation warnings that occur - any chance the library could be updated with this?