eslint-plugin-canonical icon indicating copy to clipboard operation
eslint-plugin-canonical copied to clipboard

Published 20 hours ago • verified publisher icon gajus

feat: support ESLint 9

Open brettz9 opened this issue 1 year ago • 4 comments

feat: support ESLint 9

BREAKING CHANGE:

Requires Node 18

Also:

  • chore: use flat config

Note that context.parserPath is being removed per https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context-properties%3A-parseroptions-and-parserpath-being-removed , and although it mentions a theoretical replacement, I didn't see one being supplied on context.languageOptions or context.languageOptions.parserOptions. But the rule seems to work without it.

I changed from @typescript-eslint/rule-tester as it does not work with flat configs currently.

I removed a couple duplicate test cases (as that was being warned against).

brettz9 avatar Jul 03 '24 05:07 brettz9

I'm not sure on resolving the failing CI, except that it works with --legacy-peer-deps.

brettz9 avatar Jul 03 '24 05:07 brettz9

Looks like lint stop does not work.

gajus avatar Jul 16 '24 23:07 gajus

Adding --legacy-peer-deps is fine.

gajus avatar Jul 16 '24 23:07 gajus

I might have to leave you with the TypeScript...

brettz9 avatar Jul 16 '24 23:07 brettz9

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 23 '24 14:08 github-actions[bot]