dindent icon indicating copy to clipboard operation
dindent copied to clipboard

Tag new release

Open benatespina opened this issue 8 years ago • 11 comments

Hi @gajus,

I'm using this amazing library to make project that uses the svg elements. The PR that fixes bugs related with this kind of elements has been merged months ago, but it does not exist any tag that contains the #23 PR.

So, can you tag a new release that allows to use the last merged improvements? :)

benatespina avatar Jun 05 '17 09:06 benatespina

I haven't used Composer for couple of years now. Is adding a git tag sufficient to create a new release?

gajus avatar Jun 05 '17 10:06 gajus

@gajus No, you have to add a new Git tag and then, you have to click Update button in Packagist. https://packagist.org/packages/gajus/dindent

benatespina avatar Jun 05 '17 10:06 benatespina

I've created two tags:

  • https://github.com/gajus/dindent/tree/2.3.0
  • https://github.com/gajus/dindent/tree/v2.3.0

and hit Update, but nothing is changing. Anything else I should do?

gajus avatar Jun 05 '17 10:06 gajus

I am guessing I need to update https://github.com/gajus/dindent/blob/master/composer.json#L3.

gajus avatar Jun 05 '17 10:06 gajus

Nop. Even after updating the git tags and updating the composer.json, the packagist.org does not pick up the change.

gajus avatar Jun 05 '17 10:06 gajus

Sorry, Composer does not use the version directive to determine the current tag. So, you can safely remove this directive from composer.json because it's useless in its workflow.

To make work, only you have to tag a new git release in GitHub and hit the packagist Update button. You do not need to do anything in your codebase to publish a new release in Packagist.

benatespina avatar Jun 05 '17 10:06 benatespina

@gajus is it something that can I help you?

benatespina avatar Jun 09 '17 13:06 benatespina

@gajus ping

benatespina avatar Jun 22 '17 16:06 benatespina

@gajus No, you have to add a new Git tag and then, you have to click Update button in Packagist. https://packagist.org/packages/gajus/dindent

I have already done that and Packagist does not pick up the new tag. There isn't much else I can do.

Packagist does not provide any debugging information in response to the Update the action. The network request results in 200.

gajus avatar Jun 22 '17 18:06 gajus

FIY, you can use the zip directly from github as a workaround for now:

composer.json:

...
"require" : {
	"gajus/dindent" : "2.3.0",
},
"repositories" : [{
	"type" : "package",
	"package" : {
		"name" : "gajus/dindent",
		"version" : "2.3.0",
		"dist" : {
			"url" : "https://github.com/gajus/dindent/archive/2.3.0.zip",
			"type" : "zip"
		}
	}
}]
...

Schleuse avatar Aug 01 '17 11:08 Schleuse

I have already done that and Packagist does not pick up the new tag. There isn't much else I can do.

Packagist does not provide any debugging information in response to the Update the action. The network request results in 200.

That's because when you check the contents of composer.json for tags v2.3.0 and 2.3.0, the version is still 2.0.2:

https://github.com/gajus/dindent/blob/df486a42dc092105100a48a6c8ae7aa7db1aa61a/composer.json#L3

Those tags get ignored as the version in composer.json doesn't match with the tag:

image

(I set this GitHub repository as a VCS repository in composer.json before running that command)

SharkMachine avatar May 04 '21 10:05 SharkMachine