node-properties icon indicating copy to clipboard operation
node-properties copied to clipboard

Added typescript definitions and jsdocs

Open Inrixia opened this issue 4 years ago • 4 comments

This was actually already done in this pull request: https://github.com/gagle/node-properties/pull/32 But it was never merged for some reason. I've checked and the types are all still up to date.

Inrixia avatar Mar 04 '21 08:03 Inrixia

This would be extremely useful. @gagle are there any obstacles to merging this?

hlovdal avatar Sep 18 '21 09:09 hlovdal

Is it possible we could get this merged?

KevinGhadyani-Okta avatar Feb 15 '24 17:02 KevinGhadyani-Okta

After going through this again, it looks like you need to type the callback functions. I'd expect it to be (error: Error, ...) rather than any for that type.

KevinGhadyani-Okta avatar Feb 15 '24 17:02 KevinGhadyani-Okta

Also, there's a use case for parse taking a source and callback without options. Currently, the type doesn't allow for options to be optional.

KevinGhadyani-Okta avatar Feb 15 '24 17:02 KevinGhadyani-Okta