fmdata icon indicating copy to clipboard operation
fmdata copied to clipboard

Allow control the source of field in portal indiv.

Open jakSolutionsGithub opened this issue 3 years ago • 5 comments

jakSolutionsGithub avatar May 21 '22 10:05 jakSolutionsGithub

I've approved the actions to run on this PR and there are a couple of issues. If you can get those sorted out I'll try to take a look at the code once everything is passing.

fuzzzerd avatar May 21 '22 16:05 fuzzzerd

Should be good now.

jakSolutionsGithub avatar May 22 '22 08:05 jakSolutionsGithub

This looks like a quite promising start! Can you please add a test case that covers this new feature as well so we can ensure it isn't broken by future changes?

I have been mocking the Data API Responses in a JSON file and loading that in at test time, here is a current test that can serve as a starting point. A few modifications to a clone of this test should get us there: https://github.com/fuzzzerd/fmdata/blob/564a209b74de92da7062e6ae30bc345896170abd/tests/FMData.Rest.Tests/Find.SendAsync.Tests.cs#L168-L195

fuzzzerd avatar May 23 '22 22:05 fuzzzerd

@jakSolutionsGithub, @korpinz -- just wanted to follow up and see if you saw my note about adding some test coverage for this change?

fuzzzerd avatar Jun 09 '22 22:06 fuzzzerd

@fuzzzerd -- Yeah, will try to take care of it this weekend!

jakSolutionsGithub avatar Jun 10 '22 14:06 jakSolutionsGithub

Is this still being worked on? I'm pretty sure I'm running into this limitation currently. I can think of a work around but I'd rather not. To be sure though, how many "levels" deep can we use the PortalData attribute? The one that's failing on me is on a layout that itself comes from a portal.

HollowGraphic avatar Apr 25 '23 14:04 HollowGraphic

Is this still being worked on? I'm pretty sure I'm running into this limitation currently.

I suspect this fell off @jakSolutionsGithub radar. I had requested the addition of some test coverage for this change. Once we have that I'd be inclined to approve it and create a release.

I can think of a work around but I'd rather not. To be sure though, how many "levels" deep can we use the PortalData attribute? The one that's failing on me is on a layout that itself comes from a portal.

Do you mean a portal within a portal? I'm not sure how FileMaker handles that specifically; however, the PortalData attribute just helps guide the serializer, so it should just work as long as the data structure matches.

fuzzzerd avatar Apr 25 '23 15:04 fuzzzerd

Okay, thanks. I did mean portal within a portal. I've tried a couple of things and have not been able to grab the data from embedded portals. I know the FM community has stated that portalception is not supported by FM, but, it does look like it works on the FM side. It displays the correct records. I guess I'm not sure if its doable.

HollowGraphic avatar Apr 25 '23 16:04 HollowGraphic

Feel free to open another issue or discussion on the topic. I haven't done much with portals myself, but I'd be open to exploring the possibility and finding out what itd take to get it working.

fuzzzerd avatar Apr 25 '23 17:04 fuzzzerd