func0der
func0der
The drives are found now, but the partitions do not seem be properly parsed. One thing I saw was the partition names in the partition table are missing a `p`...
I found the issue. `ReadEFI` needs to be extended. Instead of: ```bash label=${drive}$((${i}+1)); ``` We need to create the label for the partion like so: ```bash PartExt=$((${i}+1)); if [ "${drive:0:9}"...
The *Laravel* `Scope::apply()` method uses `\Illuminate\Database\Eloquent\Builder` which is a generic class as defined in this *Larastan* stub here: https://github.com/larastan/larastan/blob/2.x/stubs/common/EloquentBuilder.stub#L6 With our implementation: ``` class AnnouncementTypeScope implements Scope { /** *...
> Also note that this should work with custom builders that are not generic themselves. Since the interface of the `Scope` requires an Eloquent-Builder to be given to `apply()` as...
@calebdw Thanks for all the support. I think I managed to put something together. Also added a test case for the custom non generic builder case you mentioned.
I hope i got the tests down now ^^
@canvural You are right. My bad. This error comes only in combination with `phpstan/phpstan-strict-rules`, which are common for phpstan users though. With the generic interface solution this problem is resolved....
So no merge for this?
It's merged and released. I think we can /close this now :)
@rjd22 PR would be great. You can almost always work easier with something that is already there :)