FDWaveformView icon indicating copy to clipboard operation
FDWaveformView copied to clipboard

Added unversioned TeamID infrastructure.

Open JanX2 opened this issue 4 years ago • 6 comments

This change allows keeping the TeamID out of the project files. This way people can just clone the git repo, add their TeamID in a copy of the file "DEVELOPMENT_TEAM.xcconfig.template" then named "DEVELOPMENT_TEAM.xcconfig" and signing of the iOS Example will magically work.

This is described in detail in the file "Shared.xcconfig".

JanX2 avatar Oct 01 '21 08:10 JanX2

Thank you for sharing. Is this approach documented or advocated from anywhere?

Please see that our project setup comes from here. https://github.com/fulldecent/swift5-module-template I want to synchronize any changes we are doing with there.

fulldecent avatar Oct 01 '21 21:10 fulldecent

@fulldecent You can have a look at all the repos that I have added this to. This approach makes OSS development much easier. I tried to generate a link to a search for this, but github seems to have issues there: https://github.com/search?q=user%3AJanX2+filename%3ADEVELOPMENT_TEAM.xcconfig

I originally got the concept and idea from: https://github.com/lapcat/Bonjeff

This approach has been used here: https://github.com/JanX2/Cog

It has also been adapted from this idea here: https://github.com/JanX2/BookPlayer

This is limited to the iOS Example project. The library remains untouched.

JanX2 avatar Oct 02 '21 08:10 JanX2

Thank you for the notes.

Would like to leave the issue open for a bit to collect feedback here.

fulldecent avatar Oct 02 '21 20:10 fulldecent

@fulldecent Sure!

JanX2 avatar Oct 04 '21 15:10 JanX2

@fulldecent What are your thoughts on these changes?

JanX2 avatar Oct 26 '21 09:10 JanX2

@fulldecent Any thoughts?

JanX2 avatar Nov 10 '21 10:11 JanX2