filesystem_spec icon indicating copy to clipboard operation
filesystem_spec copied to clipboard

DirFileSystem.ls() has `detail=True` as default

Open benlindsay opened this issue 3 years ago • 7 comments

In the DirFileSystem implementation, the detail parameter is set to True by default (see here and here) whereas for other implementations like LocalFileSystem, it is set to False (see here). This makes it so that ls() will give a list of dictionaries instead of a list of strings. Can we set that parameter to False by default so it has the expected behavior?

Pinging @efiop and @lucmos since you two coded up the DirFileSystem I think. Thanks for putting that together!

benlindsay avatar Feb 02 '22 16:02 benlindsay

Yes, we would like to aim for consistency across the implementations. I suspect this particular argument may be inconsistent in more places than the one you noticed.

martindurant avatar Feb 02 '22 16:02 martindurant

Oh interesting, I see that the AbstractFileSystem sets detail=True by default, so I guess the cleanup should go in the other direction...maybe LocalFileSystem and others should change theirs to detail=True

benlindsay avatar Feb 02 '22 16:02 benlindsay

Not super related, but is there a plan to add another release soon? I'd love to use DirFileSystem in an internal app at work but it's hard without a release. Thanks!

benlindsay avatar Feb 03 '22 20:02 benlindsay

In theory, we can release whenever we have accumulated enough new stuff or something critical comes up. It doesn't cost me too. much effort. We've been doing one or two releases a month.

martindurant avatar Feb 04 '22 14:02 martindurant

@martindurant Any updates on when a new release might come out? Still really looking forward to using DirFileSystem in a project. Thanks in advance!!

benlindsay avatar Feb 22 '22 16:02 benlindsay

On PyPI now

martindurant avatar Feb 22 '22 17:02 martindurant

woohoo, thank you!!

benlindsay avatar Feb 22 '22 17:02 benlindsay