adlfs icon indicating copy to clipboard operation
adlfs copied to clipboard

support signed urls via connection string alone

Open shcheklein opened this issue 1 year ago • 6 comments

In a lot of cases we have only a connection and no account name, account key. Those could be extracted from the connection string and it's convenient to have it done automatically by the fs itself.

shcheklein avatar Jun 19 '24 01:06 shcheklein

@martindurant hey, sorry for bothering you here, do you know who is the right person to check this and do a release? thanks!

shcheklein avatar Jun 19 '24 22:06 shcheklein

@hayesgb @TomAugspurger - who is maintaining this repo these days?

martindurant avatar Jun 20 '24 13:06 martindurant

Is it possible to make a test for this change?

martindurant avatar Jun 20 '24 13:06 martindurant

Is it possible to make a test for this change?

@martindurant yep, it has a test already

shcheklein avatar Jun 20 '24 15:06 shcheklein

@hayesgb @TomAugspurger @martindurant a friendly reminder folks :)

shcheklein avatar Jun 27 '24 16:06 shcheklein

It'll be a bit before I can take a look.


From: Ivan Shcheklein @.> Sent: Thursday, June 27, 2024 11:04 AM To: fsspec/adlfs @.> Cc: Tom Augspurger @.>; Mention @.> Subject: Re: [fsspec/adlfs] support signed urls via connection string alone (PR #478)

@hayesgbhttps://github.com/hayesgb @TomAugspurgerhttps://github.com/TomAugspurger @martinduranthttps://github.com/martindurant a friendly reminder folks :)

— Reply to this email directly, view it on GitHubhttps://github.com/fsspec/adlfs/pull/478#issuecomment-2195102518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKAOIQYIDRQ5B75UGRY4R3ZJQZZDAVCNFSM6AAAAABJRCKN4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGEYDENJRHA. You are receiving this because you were mentioned.Message ID: @.***>

TomAugspurger avatar Jun 28 '24 12:06 TomAugspurger

just a friendly reminder folks, it would be great if we can merge this :)

shcheklein avatar Jul 15 '24 03:07 shcheklein

Thanks @shcheklein

TomAugspurger avatar Jul 20 '24 22:07 TomAugspurger

@TomAugspurger could you also trigger a new release please when you have a minute. Thanks!

shcheklein avatar Jul 21 '24 05:07 shcheklein

2024.7.0 is out on PyPI now: https://pypi.org/project/adlfs/

TomAugspurger avatar Jul 22 '24 12:07 TomAugspurger