FSharp.Formatting icon indicating copy to clipboard operation
FSharp.Formatting copied to clipboard

Relax FSharp.Compiler.Service dependency version

Open Thorium opened this issue 1 year ago • 1 comments

Current Nuget package states dependency: FSharp.Compiler.Service = 43.8.100

(which is corrseponding FSharp.Core 8.0.100)

But there is already new FSharp.Compiler.Service 43.8.301 (...and corresponding FSharp.Core 8.0.301)

This project should not state exact F# compiler service dependency, but rather more relaxed >=. Or if you want to keep releasing new Nuget-packages, then at least < 43.9.

Currently if I just run paket install with F# 8.0.301 then it reverts FSharp.Formatting to version 20 -> 14.0.1 where is more relaxed FSharp.Compiler.Service (>= 40.0.0)

Thorium avatar Aug 06 '24 08:08 Thorium

This project should not state exact F# compiler service dependency, but rather more relaxed

I understand the idea of having a more relaxed dependency on the F# compiler service for this project. However, I have some concerns. FCS versions don't always follow semver and can sometimes be incompatible with each other. For example, there are no release notes for 8.0.301 here: https://github.com/dotnet/fsharp/tree/main/docs/release-notes/.FSharp.Compiler.Service. So, we can't be sure if it's binary compatible with 8.0.300.

Relaxing the dependency might lead to issues if the next FCS release isn't stable for our project. It feels a bit risky, and I don't want us to run into unexpected runtime problems.

What do you think, @baronfel?

nojaf avatar Aug 06 '24 08:08 nojaf