FSharp.Data.SqlClient icon indicating copy to clipboard operation
FSharp.Data.SqlClient copied to clipboard

docs of SqlCommandProvider is missing info on TempTableDefinitions and TableVarMapping

Open chinwobble opened this issue 6 years ago • 1 comments

Description

The docs are missing info on TempTableDefinitions and TableVarMapping on the SqlCommandProvider.

Expected behavior

All options should be documented.

Actual behavior

Go to http://fsprojects.github.io/FSharp.Data.SqlClient/configuration%20and%20input.html and they are missing information and examples on what is the purpose of those two parameters.

chinwobble avatar Sep 14 '19 04:09 chinwobble

@chinwobble I've put a description on how to build / run the documentation on your end if you like to help by submitting a PR with added documentation: https://github.com/fsprojects/FSharp.Data.SqlClient/blob/1e5d276dc4842f8e8bdfb28995fc603489b2e438/CONTRIBUTING.md#contributing-to-the-docs

You can see usage of TempTableDefinitions here:

https://github.com/fsprojects/FSharp.Data.SqlClient/blob/37a6ae50b69c97e9f9c875feec52f550640fa1b4/tests/SqlClient.Tests/TempTableTests.fs#L9

and TableVarMapping here: https://github.com/fsprojects/FSharp.Data.SqlClient/blob/37a6ae50b69c97e9f9c875feec52f550640fa1b4/tests/SqlClient.Tests/TVPTests.fs#L152

smoothdeveloper avatar Sep 22 '19 12:09 smoothdeveloper