FAKE icon indicating copy to clipboard operation
FAKE copied to clipboard

Update release notes

Open Numpsy opened this issue 1 year ago • 14 comments

refs https://github.com/fsprojects/FAKE/issues/2738#issuecomment-2146284145

This is just grabbing a couple of notable changes, and I'm not sure what the next version will be, so maybe it's a placeholder than a complete change

Numpsy avatar Jun 04 '24 11:06 Numpsy

Also, the macOS CI builds might fail unless we do https://github.com/fsprojects/FAKE/pull/2773 or update the .NET SDK or something like that

Numpsy avatar Jun 04 '24 11:06 Numpsy

Looks great! Thanks @Numpsy !! 🎉🎉🎉

voronoipotato avatar Jun 04 '24 19:06 voronoipotato

Does anyone know how to fix the build?

xperiandri avatar Jun 05 '24 15:06 xperiandri

Does anyone know how to fix the build?

If the issue is https://github.com/dotnet/runtime/issues/64103 then it looks like either change the macOS runner from macOS-latest to macOS(12/13) (e.g. #2773) or update the .NET SDK used in the build to 6.0.300 or newer.

Numpsy avatar Jun 05 '24 16:06 Numpsy

@xperiandri I noticed in #2768 (which also updates release notes) that you rebased / repushed commits I did in that branch, I think it is better to just append commits and let the branch author do rebase in case it is needed, there is also concern it can mess the contribution history in github (which is nice for people that begin contribution).

#2768 should be merged and released, IMO, it is not because macOS CI fails in that particular branch, that it is related to it, most FAKE users can't leverage terminal logger goodness until it ships.

smoothdeveloper avatar Jun 05 '24 19:06 smoothdeveloper

@smoothdeveloper let's fix the build in a separate PR and rebase this one on top. Anyway, if a build does not happen I will not be able to release anything. A release also requires building 🙂

xperiandri avatar Jun 05 '24 20:06 xperiandri

@xperiandri mmh, I didn't see there are artifacts for each platform.

I'm not aware of the reason for it, as I assumed there are no non-CLI binaries shipped for fake but I'm probably overlooking something.

smoothdeveloper avatar Jun 05 '24 20:06 smoothdeveloper

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

voronoipotato avatar Jun 13 '24 19:06 voronoipotato

Submit another PR with a fix

xperiandri avatar Jun 13 '24 20:06 xperiandri

@xperiandri how do we update .net core to 6.0.5 for that the macOS-latest target so we can keep moving?

I tried doing it in #2780 and got a different error :-(

Numpsy avatar Jun 16 '24 09:06 Numpsy

Grasping at straws a bit here, but - https://github.com/fsprojects/FAKE/pull/2781. (Unclear if there is actually a real FAKE issue here on ARM cpu macs that might effect end users as well)

Numpsy avatar Jun 16 '24 10:06 Numpsy

@Numpsy maybe we should reach out to people in the slack and discord and see if anyone has an arm macbook that they can help test this with. I have an arm surface pro x, but I doubt that will be helpful.

voronoipotato avatar Jun 26 '24 21:06 voronoipotato

At this point, I think it might be nice to just try to get the build pipeline running successfully on the Intel Mac runners, and have 'fix ARM problems' as a seperate work item once there's a more stable base

Numpsy avatar Jun 27 '24 10:06 Numpsy

that seems good, I hear the rosetta x86 emulation is very good anyway, it feels like a "nice to have".

voronoipotato avatar Jun 27 '24 14:06 voronoipotato

Hurrah, build succeeded

Numpsy avatar Jul 11 '24 16:07 Numpsy