vue-at icon indicating copy to clipboard operation
vue-at copied to clipboard

component updates: handles when list is empty and handles async loading of list

Open csantiago132 opened this issue 6 years ago • 5 comments

This PR adds a couple of updates to the component;

** Changes/Updates:**

  • list of members are loaded from local state instead of props; this makes async loading and updating the list easier and automatically

New:

  • adds a prop to display when the list is empty instead of displaying nothing
  • adds a slot emptyList to display any custom component when list is empty

Breaking changes:

  • members prop got changed to list-members this is because the code is so couple to 'members' prop that its easier to change a prop instead of the whole codebase

csantiago132 avatar Sep 01 '19 21:09 csantiago132

can solve #106 and #100

csantiago132 avatar Sep 01 '19 21:09 csantiago132

Thanks, just wait for my test case being ready and once the test passed in all cases I can merge it.

fritx avatar Sep 04 '19 01:09 fritx

@fritx ok thanks for taking the time to review it!

csantiago132 avatar Sep 04 '19 15:09 csantiago132

Any update regarding the merge of this pull request? Thank you

mirkos93 avatar Sep 15 '20 10:09 mirkos93

@mirkos93 @csantiago132 sorry I can not merge the PR directly as it breaks the interface to users (for example, the prop is renamed)

fritx avatar Sep 15 '20 11:09 fritx