zipline
zipline copied to clipboard
fringd
support Rails 8.0
Rails 8.0 is out and the gemspec is currently fixed to < 8.0 which prevents us from upgrading
Would like to see this merged as well. Currently zipline is preventing me from being able to upgrade to rails 8.0
Hi @fringd, could be great to release a new version with Rails 8 support. Do you need any help to do so ?
Folks, as an interim solution - you can pull a branch from Github into your Gemfiles. Alternatively - you can replace uses of zipline with direct ZipKit calls, but that's more work.
+1 since more and more teams are migrating their projects to Rails 8. Referencing a fork in a Gemfile should be done with care and by always using 'ref' to pin a particular commit 🤔
This in your Gemfile points to the current commit as a temporary solution:
# Generate and stream zip files on the fly.
# Using fork for Rails 8 support
# See also https://github.com/fringd/zipline/pull/108
gem "zipline",
github: "alhajrahmoun/zipline",
ref: "3fcbe12b01e6399a0a4db5292addecdb267cfa03"
@fringd Would you be open to a PR that removes the upper bound on actionpack completely? Rails 8.1 released this week but the newly merged upper bound prevents upgrading.
rails makes breaking changes all the time. i'd prefer to adjust the range only after i've verified it works without any changes or when i've made any needed changes and verified it works.
that said i don't see anything in the changelog that would affect this gem. happy to change the range again.
Weird, I managed to upgrade my app to Rails 8.1, but that downgraded zipline as such:
- zipline (2.1.0)
- actionpack (>= 6.0, < 8.1)
- content_disposition (~> 1.0)
- zip_kit (~> 6, >= 6.2.0, < 7)
+ zipline (0.0.7)
+ curb
+ rails (>= 3.2.1)
+ rubyzip (>= 1.0, <= 1.1.2)
ahh i must not hhave specified the rails versions i was compatible with back then. pushed a new version. i'll see about deleting this old gem