Ram Dobson

hey sorry for the slow response. I've resolved the conflicts but see some failing tests. Could someone take a look and resolve those?

one more request. could you include a test that exercises this functionality? just verify that argments are passed along to zip tricks?

sorry i got the tests more or less good for you. they were bad on master for some reason. i think something's wrong with ruby head, disabled it for now

I'm seeing this too with latest rush and pnpm, 5.74.0 and 7.30 respectively

yeah we should handle this better. I'm not sure how, but if we could abort the whole download that's probably the best option...

i googled a bit for some possible solutions here... https://stackoverflow.com/questions/15305203/what-to-do-with-errors-when-streaming-the-body-of-an-http-request these two options seem like the best leads: 2. Write a malformed chunk (and close the connection) which will trigger...

this might be possible if the failure happened at the beginning. if it happened in the middle of the file that data has already been streamed out to the user...

that said, an errors.log would be better than nothing. i'll keep this in mind if we try the other options and can't get them working.

yeah actually that makes some sense to me... this gem is mostly for those giant downloads, so maybe just getting partial success is generally better. my worry is the user...

PRs welcome of course. I'm assuming there isn't enough local storage for files generally though, so anything that waits for a whole file before continuing is a non-starter 😕 1....