Friflo.Engine.ECS icon indicating copy to clipboard operation
Friflo.Engine.ECS copied to clipboard

Moving default components like position, rotation and transform to different namespace

Open erdemserhatergen opened this issue 1 year ago • 5 comments

Having these components default from friflo results clash with rendering frameworks like fna and mono. I'm not a C# expert so couldn't find a good way to exclude those from my includes.

Do you think it would be good idea to move them to different namespace for library?

erdemserhatergen avatar Sep 07 '24 08:09 erdemserhatergen

Doing this will break compatibility. So I don't want to do this at the moment.

friflo avatar Nov 01 '24 09:11 friflo

Similar to https://github.com/friflo/Friflo.Engine.ECS/discussions/26

friflo avatar Nov 01 '24 09:11 friflo

In case changing the mentioned types I would move them to namespace Friflo.ECS.Math. I let this topic open for better naming suggestions.

friflo avatar Nov 01 '24 15:11 friflo

i agree with @erdemserhatergen and #26, but its already been put in place so yes technically it will break compatibility. but these types didnt need to be written as included in the first place! people can implement those themselves. maybe not for EntityName so easily as i think that should be a feature native to the lib without a component in use, but definitely for pos/rot/matrix components.

as for the namespace if theyre to be moved, Friflo.ECS.Components or Friflo.ECS.BuiltIn sound more fitting than Math.

popcron avatar Nov 24 '24 14:11 popcron

In case changing the mentioned types I would move them to namespace Friflo.ECS.Math. I let this topic open for better naming suggestions.

Thanks for the information and still thinking about moving them to other namespace.

erdemserhatergen avatar Nov 24 '24 15:11 erdemserhatergen