laravel-google-analytics-4-measurement-protocol icon indicating copy to clipboard operation
laravel-google-analytics-4-measurement-protocol copied to clipboard

Moved configuring to service provider.

Open dkulyk opened this issue 4 years ago • 4 comments
trafficstars

GA4MeasurementProtocol required configuration for using. This is a problem for using it manually without package configuring.

Also need to send additional user parameters with events like user_id.

dkulyk avatar Apr 30 '21 09:04 dkulyk

Thanks for the PR Dmytro.

Also need to send additional user parameters with events like user_id.

Maybe we can have a separate PR for this to keep things simple?

gauravmak avatar May 01 '21 05:05 gauravmak

Reverted "Also need to send additional user parameters with events like user_id."

Simplified using only clientId for allow Closure for dynamic resolver for clientId

dkulyk avatar May 01 '21 14:05 dkulyk

A bit occupied these days. Will revert after 17th May, thanks.

gauravmak avatar May 08 '21 04:05 gauravmak

@dkulyk I haven't added any tests in the package yet. Reason - I wasn't sure how to.

Do you have any ideas?

gauravmak avatar May 22 '21 15:05 gauravmak