freenet-core icon indicating copy to clipboard operation
freenet-core copied to clipboard

Published 20 hours ago • verified publisher icon freenet

Docs install.md rebase

Open gogo2464 opened this issue 1 year ago • 3 comments

fix #975 rebased.

clone of https://github.com/freenet/freenet-core/pull/974

gogo2464 avatar Jan 30 '24 13:01 gogo2464

ready to merge!

gogo2464 avatar Jan 30 '24 14:01 gogo2464

@iduartgomez ready to merge!

gogo2464 avatar Jan 30 '24 20:01 gogo2464

@iduartgomez ready to merge?

gogo2464 avatar Jan 31 '24 22:01 gogo2464

should it be ready to merge?

gogo2464 avatar Mar 08 '24 15:03 gogo2464

Hello. I permit myself to ping the freenet dev because I did not have any answer since the PR used to be mergeable. I hope there should not be any rebase conflict.

The doc improovement seems very important!!!

gogo2464 avatar Apr 01 '24 14:04 gogo2464

This PR seems stale.

To fix the Cargo.lock issues just delete the file and rebase on main, that should do it. Don't run cargo update and then you should not have this issues ion every PR.

iduartgomez avatar Apr 15 '24 14:04 iduartgomez

Sorry I was over busy.

@iduartgomez is it ok if I do a rebase?

I can do it today if you want.

gogo2464 avatar Apr 15 '24 14:04 gogo2464

I open https://github.com/freenet/freenet-core/pull/1043 to solve the Cargo.lock problem and fix the comments.

al8n avatar Apr 15 '24 16:04 al8n

Closing cause it has been completed in #1043

iduartgomez avatar Apr 16 '24 07:04 iduartgomez