freeCodeCamp
freeCodeCamp copied to clipboard
feat(UI): take back to learn map after finishing a block
Checklist:
- [x] I have read and followed the contribution guidelines.
- [x] I have read and followed the how to open a pull request guide.
- [x] My pull request targets the
mainbranch of freeCodeCamp. - [x] I have tested these changes either locally on my machine, or GitPod.
Closes #49170
Now, campers are taken back to the map after finishing a block instead of directly starting the next block step-1 in Responsive Web Design Certification.
Hey @moT01, Can you please review this and let me know if any changes are to be done?
Please rebase and make sure the tests are passing. Thanks.
Thanks for your pull-request.
We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.
As always, we value all of your contributions.
Happy contributing!
Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.
Please rebase and make sure the tests are passing. Thanks. I have successfully done the rebase as you mentioned and also all tests are passing except Firefox.
You would need to update the test for the changed functionality. We have outlined working with tests in our guide. Please reach out to the Discord chat for more help :)
Thanks for your pull-request.
We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.
As always, we value all of your contributions.
Happy contributing!
Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.
Thanks for your pull-request.
We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.
As always, we value all of your contributions.
Happy contributing!
Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.
No dependency changes detected. Learn more about Socket for GitHub ↗︎
👍 No dependency changes detected in pull request
I have fixed the issue and the two tests that are failing are because of the sync fork that I did. Before doing sync fork, all tests were passing. So, I haven't done any changes to the error causing files. Is there anything else I need to do?
This PR now has irrelevant changes.
I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request
This PR now has irrelevant changes.
I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request
I tried running all the commands following the document that you sent. But still, the tests are failing because of the files that were edited after syncing fork. Can you please help me out?
I have successfully solved the issue and also all the tests are passing. Kindly review and please let me know any suggestions/changes required. And sorry for the errors that I had made. This being my first contribution, I faced some errors. I'll be more careful from next time onwards.
Thank You so much. I'll do this.
So @DEVelooper29 do you need any help with the PR still ?
I made a few updates to this - it should be good to go.
Do we want to take the camper back to the project they just completed, or to the next project?
Either way works. I like both for their own reasons. Back to the project they just completed means they can see their checkmarks (also, that's how this PR is atm). To the next project is where the next challenge is, so maybe that's better - don't know.
I would kind of prefer to leave this how it is since it's ready to go.
Thank you for your contribution to the page! 👍 We are happy to accept these changes and look forward to future contributions. 🎉