freeCodeCamp icon indicating copy to clipboard operation
freeCodeCamp copied to clipboard

feat(UI): take back to learn map after finishing a block

Open DEVelooper29 opened this issue 2 years ago • 18 comments

Checklist:

Closes #49170

Now, campers are taken back to the map after finishing a block instead of directly starting the next block step-1 in Responsive Web Design Certification.

DEVelooper29 avatar Apr 08 '23 15:04 DEVelooper29

:eyes: Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Apr 08 '23 15:04 ghost

Hey @moT01, Can you please review this and let me know if any changes are to be done?

DEVelooper29 avatar Apr 09 '23 19:04 DEVelooper29

Please rebase and make sure the tests are passing. Thanks.

raisedadead avatar Apr 11 '23 20:04 raisedadead

Thanks for your pull-request.

We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

camperbot avatar Apr 12 '23 18:04 camperbot

Please rebase and make sure the tests are passing. Thanks. I have successfully done the rebase as you mentioned and also all tests are passing except Firefox.

DEVelooper29 avatar Apr 13 '23 05:04 DEVelooper29

You would need to update the test for the changed functionality. We have outlined working with tests in our guide. Please reach out to the Discord chat for more help :)

raisedadead avatar Apr 13 '23 07:04 raisedadead

Thanks for your pull-request.

We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

camperbot avatar Apr 16 '23 09:04 camperbot

Thanks for your pull-request.

We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!


Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

camperbot avatar Apr 16 '23 09:04 camperbot

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Apr 16 '23 09:04 socket-security[bot]

I have fixed the issue and the two tests that are failing are because of the sync fork that I did. Before doing sync fork, all tests were passing. So, I haven't done any changes to the error causing files. Is there anything else I need to do?

DEVelooper29 avatar Apr 17 '23 13:04 DEVelooper29

This PR now has irrelevant changes.

I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request

raisedadead avatar Apr 17 '23 14:04 raisedadead

This PR now has irrelevant changes.

I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request

I tried running all the commands following the document that you sent. But still, the tests are failing because of the files that were edited after syncing fork. Can you please help me out?

DEVelooper29 avatar Apr 17 '23 18:04 DEVelooper29

I have successfully solved the issue and also all the tests are passing. Kindly review and please let me know any suggestions/changes required. And sorry for the errors that I had made. This being my first contribution, I faced some errors. I'll be more careful from next time onwards.

DEVelooper29 avatar Apr 18 '23 04:04 DEVelooper29

Thank You so much. I'll do this.

DEVelooper29 avatar Apr 22 '23 04:04 DEVelooper29

So @DEVelooper29 do you need any help with the PR still ?

CallmeHongmaybe avatar May 03 '23 02:05 CallmeHongmaybe

I made a few updates to this - it should be good to go.

moT01 avatar Jun 01 '23 16:06 moT01

Do we want to take the camper back to the project they just completed, or to the next project?

naomi-lgbt avatar Jun 01 '23 16:06 naomi-lgbt

Either way works. I like both for their own reasons. Back to the project they just completed means they can see their checkmarks (also, that's how this PR is atm). To the next project is where the next challenge is, so maybe that's better - don't know.

I would kind of prefer to leave this how it is since it's ready to go.

moT01 avatar Jun 01 '23 20:06 moT01

Thank you for your contribution to the page! 👍 We are happy to accept these changes and look forward to future contributions. 🎉

naomi-lgbt avatar Jun 22 '23 21:06 naomi-lgbt