feat(client): fix the position of flash message

[Sboonny]

trafficstars

Checklist:

• [x] I have read freeCodeCamp's contribution guidelines.
• [x] My pull request has a descriptive title (not a vague title like Update index.md)
• [x] My pull request targets the main branch of freeCodeCamp.
• [x] I have tested these changes either locally on my machine, or GitPod.

Closes #48910

[ghost]

:eyes: Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Legend

[Sboonny]

Not sure if you were having issues

If we create a new component using redux, I think we need to restart the environment for it to render. I am assuming because starting new environment ("opening gitpod") fixed the issue.

[moT01]

Not sure if this is a great solution, but we could add the header to all the layouts and conditionally show (hide) the nav. So the nav is still hidden on the cert and other views but the flash messages still show. It doesn't feel quite right, but it's not bad.

[raisedadead]

Not sure if this is a great solution, but we could add the header to all the layouts and conditionally show (hide) the nav.

That would be a significant UX change and need signing-off from Quincy and Ahmad. We should check with them.

[Sboonny]

Should we revert this PR https://github.com/freeCodeCamp/freeCodeCamp/pull/48861? because this is an urgent issue.

I am down to open issue for this PR and the original PR, and we come up with a solution there.

Edit: nvm opening issue suggestion, I forgot about 48910

[raisedadead]

Reverting with https://github.com/freeCodeCamp/freeCodeCamp/pull/48921, you should add the changes and make this PR a wholesome PR for the original issues and rethink the location of the message.

I am sure it's best to keep it where it already is.

[SanjeevSingh08]

assign me this issue @Sboonny