coderadio-client
coderadio-client copied to clipboard
feat: use vite testing
Checklist:
- [X] I have read freeCodeCamp's contribution guidelines.
- [X] My pull request has a descriptive title (not a vague title like
Update index.md)
Closes #301
It's a pretty huge migration but it adds both Typescript to the main files and Vite.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected]
@a2937 are you still working on this PR? i wanted to ask something if you do...
@shootermv
What's the question?
Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.
How about also move from using create-react-app and move to use vite instead?
On Tue, Oct 29, 2024, 14:36 Anna @.***> wrote:
@shootermv https://github.com/shootermv
What's the question?
Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.
— Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/coderadio-client/pull/315#issuecomment-2444086882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI . You are receiving this because you were mentioned.Message ID: @.***>
What the netlify issues you facing?
On Tue, Oct 29, 2024, 14:45 Moshe Vilner @.***> wrote:
How about also move from using create-react-app and move to use vite instead?
On Tue, Oct 29, 2024, 14:36 Anna @.***> wrote:
@shootermv https://github.com/shootermv
What's the question?
Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.
— Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/coderadio-client/pull/315#issuecomment-2444086882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI . You are receiving this because you were mentioned.Message ID: @.***>
How about also move from using create-react-app and move to use vite instead?
Except I did. I also needed Typescript. The netlify issues were updating the header rules and dealing the pages changed thing.
P.S Sorry about the next few pushes. The package.json is taking me by surprise.
i can see something is wrong with cypress test for firefox - is running without finish
Remind me to update this to use Playwright after this PR gets merged.
i think i have idea about solve "endless cypress run" issue...
how about to run the cypress only on chrome?
you can use --browser flag cypress run --browser chrome
i know i is not ideal solution, to ignore ff, but anyway , the plan is to move to playwright...
I have a crazy idea but I think I know why it's continuing forever. It's trying to load in the ChatBot that is linked to the Discord server.
i changed the cypress command at package json "scripts" to cypress run --browser chrome & tested locally. it worked at my environment...
also it may be good idea to upgrade cypress to ^13.15.1 version
is there need to be improved at this pr?