coderadio-client icon indicating copy to clipboard operation
coderadio-client copied to clipboard

feat: use vite testing

Open a2937 opened this issue 1 year ago • 12 comments

Checklist:

Closes #301

It's a pretty huge migration but it adds both Typescript to the main files and Vite.

a2937 avatar Sep 12 '24 20:09 a2937

@a2937 are you still working on this PR? i wanted to ask something if you do...

shootermv avatar Oct 29 '24 12:10 shootermv

@shootermv

What's the question?

Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.

a2937 avatar Oct 29 '24 12:10 a2937

How about also move from using create-react-app and move to use vite instead?

On Tue, Oct 29, 2024, 14:36 Anna @.***> wrote:

@shootermv https://github.com/shootermv

What's the question?

Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.

— Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/coderadio-client/pull/315#issuecomment-2444086882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI . You are receiving this because you were mentioned.Message ID: @.***>

shootermv avatar Oct 29 '24 12:10 shootermv

What the netlify issues you facing?

On Tue, Oct 29, 2024, 14:45 Moshe Vilner @.***> wrote:

How about also move from using create-react-app and move to use vite instead?

On Tue, Oct 29, 2024, 14:36 Anna @.***> wrote:

@shootermv https://github.com/shootermv

What's the question?

Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.

— Reply to this email directly, view it on GitHub https://github.com/freeCodeCamp/coderadio-client/pull/315#issuecomment-2444086882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHWQ56I3C32QNQKQZ4LZ556MXAVCNFSM6AAAAABOEAB2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGA4DMOBYGI . You are receiving this because you were mentioned.Message ID: @.***>

shootermv avatar Oct 29 '24 12:10 shootermv

How about also move from using create-react-app and move to use vite instead?

Except I did. I also needed Typescript. The netlify issues were updating the header rules and dealing the pages changed thing.

P.S Sorry about the next few pushes. The package.json is taking me by surprise.

a2937 avatar Oct 29 '24 13:10 a2937

i can see something is wrong with cypress test for firefox - is running without finish

shootermv avatar Oct 29 '24 17:10 shootermv

Remind me to update this to use Playwright after this PR gets merged.

a2937 avatar Oct 29 '24 17:10 a2937

i think i have idea about solve "endless cypress run" issue... how about to run the cypress only on chrome? you can use --browser flag cypress run --browser chrome i know i is not ideal solution, to ignore ff, but anyway , the plan is to move to playwright...

shootermv avatar Oct 31 '24 15:10 shootermv

I have a crazy idea but I think I know why it's continuing forever. It's trying to load in the ChatBot that is linked to the Discord server.

a2937 avatar Nov 01 '24 00:11 a2937

i changed the cypress command at package json "scripts" to cypress run --browser chrome & tested locally. it worked at my environment... also it may be good idea to upgrade cypress to ^13.15.1 version

shootermv avatar Nov 03 '24 07:11 shootermv

is there need to be improved at this pr?

shootermv avatar Jan 17 '25 07:01 shootermv