php-image-converter
php-image-converter copied to clipboard
Some important changes
Changed log
- Integrate StyleCI service to check PSR-2 coding style automatically on incoming commits and PRs.
- Integrate the Travis CI service, please. And it can find the bugs/errors via automatic CI build.
- Fix wrong namespace for
ImageConverterclass. - Create
helperfunction and letconvertfunction split from theImageConverterclass.
The completed Travis CI build log and StyleCI log are as follows:
- Now I got confused. I thought we agreed on not using
jensin the namespace, but now it's back again?namespace Jens\ImageConverter;https://github.com/jenstornell/php-image-converter/issues/6 - About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.
- Now I got confused. I thought we agreed on not using
jensin the namespace, but now it's back again?namespace Jens\ImageConverter;#6- About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.
- I think we can revert the namespace to the
ImageConverter. And I'm sorry I almost forget this. - Without composer, and we can rpovide the
autoload.phpfor developers to load relatedImageConverterautomatically.
This looks fine to me
Hey @jenstornell
any change this could be reviewed and merged? I'd like to use the package :)
Cheers, Peter