php-image-converter icon indicating copy to clipboard operation
php-image-converter copied to clipboard

Some important changes

Open peter279k opened this issue 6 years ago • 4 comments

Changed log

  • Integrate StyleCI service to check PSR-2 coding style automatically on incoming commits and PRs.
  • Integrate the Travis CI service, please. And it can find the bugs/errors via automatic CI build.
  • Fix wrong namespace for ImageConverter class.
  • Create helper function and let convert function split from the ImageConverter class.

The completed Travis CI build log and StyleCI log are as follows:

peter279k avatar May 11 '19 18:05 peter279k

  1. Now I got confused. I thought we agreed on not using jens in the namespace, but now it's back again? namespace Jens\ImageConverter; https://github.com/jenstornell/php-image-converter/issues/6
  2. About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.

jenstornell avatar May 12 '19 07:05 jenstornell

  1. Now I got confused. I thought we agreed on not using jens in the namespace, but now it's back again? namespace Jens\ImageConverter; #6
  2. About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.
  1. I think we can revert the namespace to the ImageConverter. And I'm sorry I almost forget this.
  2. Without composer, and we can rpovide the autoload.php for developers to load related ImageConverter automatically.

peter279k avatar May 12 '19 08:05 peter279k

This looks fine to me

lablnet avatar Sep 08 '20 02:09 lablnet

Hey @jenstornell

any change this could be reviewed and merged? I'd like to use the package :)

Cheers, Peter

spekulatius avatar May 29 '21 13:05 spekulatius