get_connector returns True when the connection is new, preventing new connections

Open AwuyaDaniel opened this issue 3 years ago • 1 comments

https://github.com/frappe/insights/blob/6b96af3356bfa560db7e616af7e7397b03595922/insights/insights/doctype/insights_data_source/insights_data_source.py#L45

There seem to be a problem connecting to the remote Database on the new update made on the insight repo

the function get_connector() on the insight_data_source.py will always return true(1) when a new remote DB is created then returning a none value

Oct 13 '22 10:10 AwuyaDaniel

Should be fixed with 68398e30dc1ccd2928aed2a6c849dbcabe8ebb5d, can you check?

Oct 13 '22 21:10 nextchamp-saqib