qtkeychain icon indicating copy to clipboard operation
qtkeychain copied to clipboard

0.13.2 fails building with Qt 6.5.0

Open KitsuneRal opened this issue 2 years ago • 7 comments

It seems that moc is tripping over a line in kwallet_interface.h with the following message (see https://github.com/quotient-im/Quaternion/actions/runs/4526307013/jobs/7971384083 for the full log):

FAILED: moc_kwallet_interface.cpp /home/runner/work/Quaternion/Quaternion/qtkeychain/build/moc_kwallet_interface.cpp 
cd /home/runner/work/Quaternion/Quaternion/qtkeychain/build && /home/runner/work/Quaternion/Qt/6.5.0/gcc_64/./libexec/moc @/home/runner/work/Quaternion/Quaternion/qtkeychain/build/moc_kwallet_interface.cpp_parameters
/home/runner/work/Quaternion/Quaternion/qtkeychain/build/kwallet_interface.h:196:1: error: Not a signal or slot declaration

Building the same code with Qt 6.4 runs fine

KitsuneRal avatar Mar 27 '23 06:03 KitsuneRal

I can't reproduce this with the official Qt 6.5.0/gcc_64 from the Qt online installer, on Ubuntu 22.04, gcc 12.1 (Ubuntu 12.1.0). Can you paste the generated code around kwallet_interface.h:196 (-5/+5 lines or so)?

frankosterfeld avatar May 12 '23 09:05 frankosterfeld

Is this also an issue with Qt 6.5.1?

frankosterfeld avatar Jun 04 '23 16:06 frankosterfeld

yes: https://bugs.gentoo.org/908384 - this has kwallet_interface.h attached.

fwiw though, I can't reproduce it with 6.5.1 either-

a17r avatar Jun 13 '23 09:06 a17r

same with self compiled Qt 6.6 on arch with main and 0.14 branches

Seqularise avatar Jun 19 '23 10:06 Seqularise

Seems like moc stumbles over the Q_NOREPLY (qtdbus-specific macro) in the method signature, at least this is the first usage of that (out of two) in the file. I'm not sure though why it fails there, my moc (6.5.1 gcc_64 from official installer) seems fine with it. Maybe I try self-compiled 6.5/6.6 later.

frankosterfeld avatar Jun 22 '23 15:06 frankosterfeld

This suspiciously looks like https://code.qt.io/cgit/qt/qtbase.git/commit/?h=6.5.1&id=50d4e338cf11e83e9d8bb1e0254da60cc528a666 missing, that problem hit several KF modules as well. If it's that, it's not fixable/workaroundable here.

vkrause avatar Jun 22 '23 16:06 vkrause

Fixed upstream with next releases. https://bugreports.qt.io/browse/QTBUG-111330

jospezial avatar Jun 26 '23 07:06 jospezial

Latest 0.14.3 with Qt 6.7.2 is OK. I think that this ticket can be closed.

kloczek avatar Jun 23 '24 16:06 kloczek

Thanks for confirming.

frankosterfeld avatar Jun 24 '24 09:06 frankosterfeld