DigiView-Android icon indicating copy to clipboard operation
DigiView-Android copied to clipboard

Feature/rtmp stream screen

Open omouren opened this issue 4 years ago • 5 comments

WIP An other approach for the RTMP stream by recording the entire screen. Previous PR : https://github.com/fpvout/DigiView-Android/pull/75

Advantage of a full screen recording : simpler in code, handled natively by Android (MediaProjection), can continue to stream without the video (during a lipo switch for exemple) Disadvantage : it records all the screen in background, even when you switch to an other app or receive a notification, it's not a direct video from USB streaming.

Made some refactor with the overlay/buttons/watermark display/hide + Some wording update for french translations (https://github.com/fpvout/DigiView-Android/pull/80)

If someone can make an icon for a "start live" and "stop live" button maybe? You're welcome!

Todo :

  • [x] ~~We should find a way to keep a preview of the video stream~~ Not a problem here
  • [x] Add RTMP settings : RTMP URL / Key - Output resolution / Bitrate / FPS
  • [x] Add buttons to start/stop stream
  • [x] Handle RTMP server error (show in Toast)
  • [x] RTMP basic auth settings
  • [x] Audio source? From microphone or internal audio (internal audio option ONLY from API 29)
  • [x] Mute audio button
  • [x] Show some streaming stats (bitrate/fps) ? (Bitrate added)
  • [x] New "start live" and "stop live" icons ?

omouren avatar May 31 '21 12:05 omouren

Actually, I think it can be a better solution than direct stream from the socket, as you mentionned, we don't want the stream to cut on lipo changes, or goggle disconnections, even more if we add mic audio to the stream !

Maybe adding an option to display front cam / back cam in the bottom left corner, would be great (then you have like a real stream app feature !)

I will review the code tomorrow ^^

jlucidar avatar May 31 '21 21:05 jlucidar

Actually, I think it can be a better solution than direct stream from the socket, as you mentionned, we don't want the stream to cut on lipo changes, or goggle disconnections, even more if we add mic audio to the stream !

Maybe adding an option to display front cam / back cam in the bottom left corner, would be great (then you have like a real stream app feature !)

I will review the code tomorrow ^^

I had the same idea for the camera, I think it would be a nice to have!

omouren avatar Jun 01 '21 17:06 omouren

Let's make it a separate feature though, it could be useful on DVR too ^^

Le mar. 1 juin 2021 à 19:02, Olivier Mouren @.***> a écrit :

Actually, I think it can be a better solution than direct stream from the socket, as you mentionned, we don't want the stream to cut on lipo changes, or goggle disconnections, even more if we add mic audio to the stream !

Maybe adding an option to display front cam / back cam in the bottom left corner, would be great (then you have like a real stream app feature !)

I will review the code tomorrow ^^

I had the same idea for the camera, I think it would be a nice to have!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fpvout/DigiView-Android/pull/79#issuecomment-852290175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYWCUQTWTPWPIVURFELETLTQUHD3ANCNFSM452Y4IFQ .

jlucidar avatar Jun 01 '21 17:06 jlucidar

Screenshot_20210601-214921 Screenshot_20210601-214727

omouren avatar Jun 01 '21 19:06 omouren

Cool ! Would be neat to add the stat as requested by #44 . will work for now, but I think it will look better :)

jlucidar avatar Jun 01 '21 20:06 jlucidar